[SCHEDULER-1041]  Dome open/close optimization and more
Type Enhancement
Priority High
Severity Minor
Component Dispatch Scheduler Engine
Fixed In Version [8.08.0
Versions Affected [3.5.33.5.3
Severity Closed
Resolution Complete
Reported By Bob Denny
Resources Bob Denny
Start Date 1/31/2015

Description
Option to only open dome in evening right whe the  first target is started. Option to close dome after some period of inactivity. This came from Adam Block.

NOTE: THIS EXPANDED INTO A SWEEPING OVERHAUL AND REFACTORING.

Comments
6/15/2015 8:01:23 AM   Bob Denny
After last problem, this is looking good. Closing.
5/4/2015 7:26:23 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 589
Affected files /trunk/Scheduler/Engine.cs (Modified)
Check-in comment Oops, if weather unsafe at dawn, and sky flats requested, it never gets past the dawn flats into dawn cal & shutdown. Also fix the equivalent at dusk to prevent starting dusk flats too late. GEM:1041
5/4/2015 5:17:47 PM   Bob Denny
See this Comm Center thread by Mark Williams. Genuine bug!
4/3/2015 2:51:03 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 565
Affected files /trunk/Help/RelNotes.htm (Modified)
Check-in comment Release notes for sky flat timing and dome/roof for the simulator sequencer. GEM:1041
4/3/2015 10:15:39 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 563
Affected files /trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
Check-in comment Completing the timing of sky flats to hi and lo sun angles in AutoFlatConfig. Fix up simulator sequencer for startup and shutdown realism. GEM:1041
4/2/2015 8:48:32 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 562
Affected files /trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/ISequencer.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
Check-in comment Adjust timing of sky flats to the TwilightSunHi/TwilightSunLo altitudes in ACP AutoFlatConfig. GEM:1041
4/2/2015 6:37:18 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 561
Affected files /trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/ConfigForm.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/ISequencer.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
Check-in comment Checkpoint after a day of refactoring and testing. This is the main diurnal loop in Scheduler. GEM:1041
4/1/2015 5:16:57 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 560
Affected files /trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
/trunk/SchedulerSetup/SchedulerSetup.vdproj (Modified)
Check-in comment More work for delayed dome opening, etc. New rev on the setup for test customer. GEM:1041
3/30/2015 3:09:17 PM   Bob Denny
There were several problems with the startup sequencing. I think I have them fixed now and it will start with the dome closed. Tough crap if the customer's startup script causes the scope to hit the roof. NEED WARNING ABOUT THIS!!! This has been the case all along anyway.
3/30/2015 1:55:24 PM   Bob Denny
OK, Mark Williams wants to be able to start up with unsafe weather, then open when the weather is safe, which makes sense. CAUTION FOR DANGEROUS ROOFS!

I see a flaw in the evening tasks still so I need to work on this some more!

Back to In Progress
2/23/2015 12:52:16 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 541
Affected files /trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
Check-in comment Allow ISequencer.SlewTime() to work with disconnected/shutdown scope. Add assert traps to simulator to catch attempts to do things with shut down observatory. Verify that checking slew limits can be done with disconnected/shutdown obs. GEM:1041
2/23/2015 11:57:06 AM   Bob Denny
Ugh, this is really horrible. My whole architecture for keeping stats is now compromised ... we're starting the observatory during dispatching. DAMN IT!!! I can't do this, somehow I need to dispatch without a running observatory. At the moment I need to know how long the scope takes to get on target. What if I return 0? The damn observatory is going to have to start up which will throw everything off anyway. Punt!
2/19/2015 10:47:49 AM   Bob Denny
Two problems with Pre-#6.

2/13/2015 11:27:05 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 537
Affected files /trunk/Help/Advanced.htm (Modified)
/trunk/Help/Concepts.htm (Modified)
/trunk/Help/RelNotes.htm (Modified)
/trunk/Help/ScheduleCycle.htm (Modified)
Check-in comment Additional documentation on the Close-If-Idle option. GEM:1041
2/13/2015 11:02:42 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 536
Affected files /trunk/Scheduler/Engine.cs (Modified)
Check-in comment Oops! Check for running plans before deciding if you can close up for lack of work! GEM:1041
2/13/2015 10:53:28 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 535
Affected files /trunk/Scheduler/ConfigForm.cs (Modified)
Check-in comment Forgot edit comment on this for the Close-If-Idle addition. Back dated. GEM:1041
2/13/2015 9:01:20 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 532
Affected files /trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/SkyMath.cs (Modified)
Check-in comment A couple of cleanups in code. GEM:1041
2/12/2015 1:49:47 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 531
Affected files /trunk/Scheduler/Constraints.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/MainForm.cs (Modified)
/trunk/Scheduler/SkyMath.cs (Modified)
/trunk/Scheduler/TestProjectForm.cs (Modified)
Check-in comment *checkpoint* Refactoring of some SkyMath properties and methods, fix close-if-idle logic for "no pending plans" case. GEM:1041
2/12/2015 10:42:08 AM   Bob Denny
Decided to refactor weather polling into a common function. This was a mess with the separate poll function and the n the static bool.
2/11/2015 6:50:47 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 530
Affected files /trunk/Scheduler/Engine.cs (Modified)
Check-in comment Many changes and additions resulting from testing with weather unsafe at various points in the process. GEM:1041
2/11/2015 11:50:05 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 528
Affected files /trunk/Database/Database.cs (Modified)
/trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
Check-in comment Fix leakage of Observation.AcquireNow flags. I think these came from errors during simulation. GEM:1041
2/11/2015 11:28:37 AM   Bob Denny
Damn, found a bunch of Observations with Observation.AcquireNow set. Don't know how it's possible. Prevent this proactively in the future.
2/10/2015 10:51:38 AM   Bob Denny
See this Comm Center thread. Need to document the limitations of this feature. The log from Rob is also attached to this ticket.
2/10/2015 10:42:55 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 527
Affected files /trunk/Scheduler/AssemblyInfo.cs (Modified)
Check-in comment Test article - 3.8.5.1 in version. GEM:1041
2/9/2015 2:30:05 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 526
Affected files /trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
Check-in comment Fix so can start with scope disconnected (slew settle time during time span calculations). Add notation to Engine code no logic change. GEM:1041
2/4/2015 9:44:45 AM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 524
Affected files /trunk/Empty SchedulerData.mdb (Modified)
Check-in comment Oops forgot Empty SchedulerData.mdb with new query and V2.5. GEM:1041
2/2/2015 4:38:30 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 522
Affected files /trunk/Database/Database.cs (Modified)
/trunk/Help/Advanced.htm (Modified)
/trunk/Help/RelNotes.htm (Modified)
/trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/ConfigForm.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
/trunk/SchedulerSetup/Custom Actions/UpdateDatabase.vbs (Modified)
/trunk/SchedulerSetup/SchedulerSetup.vdproj (Modified)
Check-in comment Mark setup for 3.8.5. Close-if-idle-for and other tweaks for schedule cycle and schedule pass. GEM:1041
2/2/2015 3:51:20 PM   Bob Denny
OK, i think I have it (mostly or all of it maybe) for Pre-Release 5.
1/31/2015 8:38:13 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 521
Affected files /trunk/Database/Database.cs (Modified)
/trunk/Scheduler/ConfigForm.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
Check-in comment Dome closure on idle, etc. NOT COMPLETE - CHECKPOINT ONLY GEM:1041
1/31/2015 8:37:29 PM   Bob Denny
Getting there. Major refactoring of the schedule pass and open/close logic (scary). Needs extensive testing. Right now it doesn't look like it closes the dome after a late target after successfully closing it for an early target with > n hours of dead time. There is >n hours dead time after the late target.

Needs testing for periodic AF also. As it is now, the periodic AFs will NOT happen by themselves any more, they will only be done just before an Observation if the AF interval has expired. The idea is to prevent periodic AFs from causing a re-open. Need tests with a full plate as well. Also a test with the late target just before sunrise to make sure it won't close if sunrise is closer than n hours.
11/4/2014 10:23:09 AM   Bob Denny
He repeated this in Nov 2014 in this Comm Center thread.

This is related to SCHEDULER-1234 which would allow panel flats and cal frames to be done during this dead time before closing up. 

Make this an option so the obs can be kept on standby for targets of opportunity (GRB).