[ACP-1140]  Util.IsGEMDestinationWest() needs Dec
Type Change Request
Priority Medium
Severity Minor
Component AcquireImages script, AcquireSupport library, Main Program
Fixed In Version [7.2] 7.2
Versions Affected [7.1] 7.1
Severity Closed
Resolution Complete
Reported By Bob Denny
Resources Bob Denny
Start Date 7/12/2014

Description 
Add a new call Util.IsGemDestinationWest2(RA, Dec) that will result in a call to ASCOM.Telescope.DestinationSideOfPier(RA, Dec) instead of ASCOM.Telescope.DestinationSideOfPier(RA, 0) (which Util.IsGemDestinationWest(RA) does now). Then modify AcquireImages.js and AcquireScheduler.vbs and any other scripts that use Util.IsGemDestinationWest(RA) to instead use Util.IsGemDestinationWest2(RA, Dec).

Comments
7/12/2014 6:50:42 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  684
 

 

  Affected files
  /trunk/AcquireSupport.wsc (Modified)
/trunk/Script Components Master/AcquireSupport.wsc (Modified)

 

 

  Check-in comment
  Damn it, I left the error="true" in AcquireSupport
GEM:1140
7/12/2014 12:00:30 PM   Bob Denny 

    
        

            SVN Comment
        

        

            Author
            rbdenny
        

        

            Repository
            svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
        

        

            SVN Revision
            682
        

        

            Affected files
            /trunk/ACP Help/ProgRef.chm (Modified)

            /trunk/ACP Help/Programmer's Reference/ACP2 Programmer's Reference.mdb (Modified)

            /trunk/ACP Help/Programmer's Reference/doc/ProgRef.chm (Modified)

            /trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhc (Modified)

            /trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilMETHIsGEMDestinationWest.htm (Modified)

            /trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilMETHShellExec.htm (Modified)

            /trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilMETHShellExecAdmin.htm (Added)

            /trunk/ACP Help/index.htm (Modified)

            /trunk/ACP Help/relnotes.htm (Modified)

            /trunk/ACP Interop Assembly (Scheduler)/Interop.ACP.7.2.dll (Modified)

            /trunk/ACP Interop Assembly (Scheduler)/Interop.ACP.dll (Modified)

            /trunk/AcquireSupport.wsc (Modified)

            /trunk/CorrectedTelescope.cls (Modified)

            /trunk/DomeControl.cls (Modified)

            /trunk/MaxPoint Stuff/Error Generator/PointingErrorGenerator.cls (Modified)

            /trunk/MaxPoint Stuff/Error Generator/PointingErrorGenerator.dll (Modified)

            /trunk/MaxPoint Stuff/Error Generator/PointingErrorGenerator.exp (Modified)

            /trunk/MaxPoint Stuff/Error Generator/PointingErrorGenerator.lib (Modified)

            /trunk/MaxPoint Stuff/Error Generator/PointingErrorGenerator.vbp (Modified)

            /trunk/MaxPoint Stuff/Error Generator/PointingErrorGenerator.vbw (Modified)

            /trunk/Script Components Master/AcquireSupport.wsc (Modified)

            /trunk/Scripts/AcquireImages.js (Modified)

            		
        

        

            Check-in comment
            Changes for Util.IsGEMDestinationWest() and ShellExecAdmin() GEM:1176 GEM:1140
7/12/2014 9:16:36 AM   Bob Denny 
Retain the existing function name but add the Dec parameter as an optional with default=0. This will minimize my exposure to missing calls to this without the Dec, which is itself an obscure problem.
7/10/2014 6:41:37 PM   Bob Denny 
Note the other related ticket that would cause an API change, etc.
6/10/2014 9:46:07 AM   Bob Denny 
This came up with Philipp Keller who returns unknown for coordinates outside his safety limits.