[SCHEDULER-1454]  Plan Completion for Best Efforts does not send email
Type Bug
Priority High
Severity Minor
Component Dispatch Scheduler Engine
Fixed In Version [8.18.1
Versions Affected [8.08.0
Severity Closed
Resolution Complete
Reported By Bob Denny
Resources Bob Denny
Start Date 6/4/2016

Description
See this Comm Center thread by Geoff Stone. The UpdatePlanAndObs() function in the engine does not have a case for a best efforts completion of an Observation, which is a "completion" of the Plan.

Comments
2/2/2018 7:31:58 PM   Bob Denny
Got it. Changes were part of those for GEM:1575. See SVN commits in that one.
12/21/2016 11:40:20 AM   Bob Denny
REOPENED

See this Comm Center thread from Bruce McMath. The new calls to send plan notices are not honoring the "Send plan notices" (internally s_EmailPlanNotices). Programmer error!
6/4/2016 2:50:23 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 621
Affected files /trunk/Help/RelNotes.htm (Modified)
/trunk/Scheduler/Engine.cs (Modified)
Check-in comment Send plan completion emails for best efforts plans which complete early (5 cases). Also send plan completion emails to both the Project Owner/user and to the Project Contact if the email addresses are different. GEM:1454
6/4/2016 11:49:57 AM   Bob Denny
Much deeper. There are 5 places where best efforts can complete. They all need their own SendEmail() calls. Refactor SendEmail to take optional Plan pointer and have it assemble the addresses there. Then I can call it from multiple places (including the best efforts completion logic).