[SCHEDULER-1723]  Fixed time observation will run later even if weather unsafe at scheduled time
Type Bug
Priority High
Severity Minor
Component Dispatch Scheduler Engine
Fixed In Version [9.0] 9.0
Versions Affected [8.2.2] 8.2.2
Severity Closed
Resolution Complete
Reported By Bob Denny
Resources Bob Denny
Start Date 1/15/2021

Description 
See this Comm Center thread by Dick Berg. If the weather is unsafe at the time a fixed time Plan is supposed to be initiated, It remains running and will start later when the weather returns to safe, even though its time has long since passed. See Engine.cs at line 2521. Must detect this condition here, and check the handling of earliest/latest to make sure it's OK to have the two times separated ti give a window of acceptability. If there is no window, then it gets one chance, and could easily start a hair late. Give it at least two wake times.

Comments
3/24/2021 9:46:49 AM   Bob Denny 
Closing per Dick.
3/23/2021 12:05:31 PM   Bob Denny 
Asked if OK to close now.
1/21/2021 12:30:29 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
 

 

  SVN Revision
  856
 

 

  Affected files
  /trunk/Help/Advanced.htm (Modified)
/trunk/Help/Concepts.htm (Modified)
/trunk/Help/RelNotes.htm (Modified)
/trunk/Scheduler/AssemblyInfo.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)

 

 

  Check-in comment
  More testing and fixed-time documentation. 8.3.8 Private Build
GEM:1723
1/20/2021 3:49:15 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
 

 

  SVN Revision
  855
 

 

  Affected files
  /trunk/Scheduler/Engine.cs (Modified)

 

 

  Check-in comment
  Considerable more testing. It is looking great. Docs yet to be updated.
GEM:1723
1/20/2021 2:34:01 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
 

 

  SVN Revision
  854
 

 

  Affected files
  /trunk/Help/RelNotes.htm (Modified)
/trunk/Scheduler/Engine.cs (Modified)

 

 

  Check-in comment
  Oops, release notes and edit tracks in source for the changes in yesterday's SVN Rev.853
GEM:1723
1/19/2021 4:33:03 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
 

 

  SVN Revision
  853
 

 

  Affected files
  /trunk/Scheduler/Engine.cs (Modified)

 

 

  Check-in comment
  More testing. One big hole found if Plan has Fixed Time without both a start and an end time. Completed heavy load regression test with overlapping fixed time and overbooked random single images. Working so far. Much more testing needed. Docs are unclear on the meaning of start and end times when Fixed-Time and with or without Monitor Mode. 
GEM:1723
1/19/2021 3:03:17 PM   Bob Denny 
Found that monitor mode for fixed time will not bump by 24 hours if there is a Latest time. Remove this limitation.
1/18/2021 5:28:01 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
 

 

  SVN Revision
  852
 

 

  Affected files
  /trunk/Scheduler/Engine.cs (Modified)

 

 

  Check-in comment
  Work in progress ... Extensive regression testing not completed.
GEM:1723
1/18/2021 5:09:23 PM   Bob Denny 
OPened a can of worms. Unfortunately the fix for Marco Rochetto was insufficient.
1/13/2021 3:32:12 PM   Bob Denny 
This was supposed to be fixed in SCHEDULER-1684 and in the logic and exit tracks it appears that it was indeed. Will ask for logs.





// 18-Mar-19 rbd  8.2.5 (8.2b) GEM:1684 Do not resubmit fixed-time Plans

//      on weather unsafe failure. Furthermore, don't start

//      fixed-time plans whose "latest start" time has passed.
1/12/2021 4:32:42 PM   Bob Denny 
Now (Jan 2021) 8.3, this is line 2620.