[SCHEDULER-397]  Attempt to open dome with unsafe weather
Type Bug
Priority Medium
Severity Major
Component Dispatch Scheduler Engine
Fixed In Version [3.33.3
Versions Affected [3.23.2
Severity Closed
Resolution Complete
Reported By Bob Denny
Resources Bob Denny
Start Date 3/20/2010

Description
If the dispatcher runs through the day and the weather is bad approaching the next night, when it is time to open up, it does so then tries to open the dome. At this point it dies with a message "Attempt to open dome with unsafe weather".

Comments
3/27/2010 4:16:32 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 92
Affected files /trunk/Help/RelNotes.htm (Modified)
Check-in comment Oops, forgot to add this to the Release Notes for 3.3. GEM:397
3/27/2010 4:12:21 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 91
Affected files /trunk/Scheduler/Engine.cs (Modified)
Check-in comment Catch DOStartupIf(false) for dawn cal frames, allow startup even if bad weather. GEM:397
3/27/2010 4:07:46 PM   Bob Denny
Woah! Found another "running with weather bad" condition. If the obs stays closed (unstarted) all night, the weather is bad (or dome locked down), in the morning it tries to start up for dawn cal frames. These may be done in bad weather. However, the scheduler dies with "DoStartupIf() called with unsafe weather". Right, it's OK to start things up for dawn cal frames! Move the bad weather assert to inside the logic that actually opens the dome, so a call to DoStartupIf(false) will run normally even if the weather is bad.
3/20/2010 8:10:39 PM   Bob Denny
Being tested at NMSkies BigDome.
3/20/2010 8:09:28 PM   Bob Denny
SVN Comment
Author rbdenny
Repository svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/scheduler
SVN Revision 90
Affected files /trunk/Scheduler/ACPSequencer.cs (Modified)
/trunk/Scheduler/AssemblyInfo.cs (Modified)
/trunk/Scheduler/Engine.cs (Modified)
/trunk/Scheduler/ISequencer.cs (Modified)
/trunk/Scheduler/SimulatorSequencer.cs (Modified)
Check-in comment This is Scheduler 3.1.3. Upon attaching a sequencer, assure that if a weather server is available, it is connected right then. A few other small changes caught along the way, see the comments in the committed files. GEM:397
3/20/2010 6:19:28 PM   Bob Denny
Wow, research uncovered a mess with DoStartupIf() returning false to indicate that a startup was not actually done due to the obs being started. It also returns false if the startup was not done due to bad weather. That's gonna cause problems with all of the calls to DoStartupIf() that test the return! This will need an overhaul.
3/20/2010 5:59:28 PM   Bob Denny
Wow, this has been sporadic for  long time. Finally figured it out. If ACP's weather is not connected in the afternoon, the scheduler assumes the weather is good. PollWeather() gets the ACP sequencer's WeatherSafe property, calling FilteredWeatherSafe() which returns true if no weather is available. So the scheduler calls DoStartupIf(true) which runs the startup script then tries to open the dome (true parameter). The startup script connects the weather in ACP. The weather is bad now, and when it tries to open the dome boom! It's trying to open the dome with bad weather.