Need to reconsider all of the quirks with guiding and  AO bumping (see ACP-478, ACP-546, ACP-586, ACP-629, and ACP-1562) as well as the need for the internal/external guide selection and the guide camera rotation angle (addressed long ago). Is there a way to present the settings in an elegant and unified way with the quirks included?



This involved reverse polarity in various forms. [added for searching]

Another data point from Travis Deyoe at Mt Lemmon Sky Center. This was for the about to be release ACP 9.

Don Elledge's results (for the record here - he has a Planewave Alt/Az, so no GEMLooksWest stuff):




So for the team, I have analyzed the results.



on the 0 angle, we got a PA of 359 and an off axis guider at 92 degrees. 



02:02:17 PA=359 (off-axis guider @ 92.0 deg)
02:02:17 Guide angle is 91.2 deg.
02:02:17 (Setting up rotated AO bumping polarities)
02:02:17 (switches are true,true,true)



This produced a a guide angle of 91.2 degree. and the results are for an OAG at 90 Degrees according to the paper.



Maxim Produced the results (True, False, True) which are the results of an Internal Guider at 270 degrees according to the paper.



PA=91 (off-axis guider @ 92.0 deg)
02:46:27 Guide angle is -176.8 deg.
02:46:27 (Setting up rotated AO bumping polarities)
02:46:27 (switches are true,false,false)



this produced a a guide angle of -176.8 degrees and the results are for an OAG at 180 Degrees according to the paper.



Maxim Produced the results (False, False False) which are the results of an Internal Guider at 0 degrees according to the paper.



03:18:08 PA=181 (off-axis guider @ 92.0 deg)
03:18:08 Guide angle is -87.2 deg.
03:18:08 (Setting up rotated AO bumping polarities)
03:18:08 (switches are false,false,true)



this produced a guide angle of -87.2 degrees and the results are for an OAG at 270 Degrees according to the paper.



Maxim Produced the results (False, True, True) which are the results of an Internal Guider at 90 degrees according to the paper.



First: I need to do is set up the guider as an internal guider instead of an external OAG. This is an external STX-guider that sits in front of the filter wheel but it seems to flip the image correctly like an internal guider. There is a section in the instructions that you talk about STX having their guide chips at 90 degree angles, might want to add that the external STX guider also operates like the internal guide chip.



Second, system operates like its 180 degrees off on all axes. So ACP moves the system basically in the opposite direction then what we are telling it to do. 



Anyway, I hope this helps. Let me know how i can correct this



don

While analyzing the data in this Comm Center post by Don Elledge, I found a fencepost error in the Rotate(PA) function in AcquireSupport. "How did this ever work?" For small negative PA inputs, it produces an undefined switch vector. Calculation needs to be modulo 4!

I am not addressing this for ACP 8.2. No one else has complained about the AO, maybe some stuff has been fixed at Diffraction, and I am not going to throw all of this out for a fresh start again. Changing to Assigned and will review after the release.

REOPENED




See this Comm Center thread by Jeff Lewis. I am seeing that his system with guider cables, Paramount, and an internal guider (STL6303E) requires a Y reversal and does NOT require the guide angle reversal. See the attached Javascript with the logic changes needed to produce the correct bumping polarities on Lewis' system



Also see ACP-1562 and its new requirements. 



This will trigger another major review and possible redesign of this to handle even more cases of guider control and optical paths (to include reflections introduced by instrument selectors etc). 

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
864
 
 

  
Affected files
  
/trunk/ACP Help/relnotes.htm (Modified)

 
 

  
Check-in comment
  
Release notes for AP bumping fix
GEM:626

 

Mike and Jimmy report that the guiding is OK. This will cause an 8.1 of ACP, but will wait for other issues and just replace AcquireSupport on other AO systems for now. There aren't very many.

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
861
 
 

  
Affected files
  
/trunk/AcquireSupport.wsc (Modified)
/trunk/Script Components Master/AcquireSupport.wsc (Modified)

 
 

  
Check-in comment
  
Correct the previous fix for removal of ai/ao variables used in ancient MaxIm bump angle hack.
GEM:626

 

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
860
 
 

  
Affected files
  
/trunk/AcquireSupport.wsc (Modified)
/trunk/Script Components Master/AcquireSupport.wsc (Modified)

 
 

  
Check-in comment
  
Reopening this persistent issue. Fix AO bumping on GEM and behavior of new ReverseY switch.
GEM:626

 

REOPENED



The AO bumping flip/reversal logic doesn't work, and on inspection today it looks flawed. I updated it and have it out to test with Mike Miller/Jimmy Walker.

Testers are giving positive feedback. We may have it!

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
839
 
 

  
Affected files
  
/trunk/ACP Help/relnotes.htm (Modified)

 
 

  
Check-in comment
  
Spelling error in release notes.
GEM:626

 

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
837
 
 

  
Affected files
  
/trunk/ACP Help/ProgRef.chm (Modified)
/trunk/ACP Help/Programmer's Reference/ACP2 Programmer's Reference.mdb (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.chm (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhc (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhk (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPReverseYonFlip.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPSensorAngle.htm (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPSensorPlateScale.htm (Modified)
/trunk/ACP Help/autoguide.htm (Modified)
/trunk/ACP Help/relnotes.htm (Modified)
/trunk/ACP Help/rotator.htm (Modified)
/trunk/doc/ProgRef.chm (Modified)

 
 

  
Check-in comment
  
Doc changes for guiding improvements(mixed between two Gemini issues GEM:1350)
GEM:626

 

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
835
 
 

  
Affected files
  
/trunk/AcquireSupport.wsc (Modified)
/trunk/Script Components Master/AcquireSupport.wsc (Modified)

 
 

  
Check-in comment
  
New ReverseYonFLip setting. Refactor guiding setup for simplicity and consistency.
GEM:626

 

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
834
 
 

  
Affected files
  
/trunk/Script Components Master/AcquireSupport.wsc (Modified)

 
 

  
Check-in comment
  
Script changes ready for testing (Steve Reilly)
GEM:626

 

 

  
SVN Comment
 
 

  
Author
  
rbdenny
 
 

  
Repository
  
svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 
 

  
SVN Revision
  
833
 
 

  
Affected files
  
/trunk/ACP Help/autoguide.htm (Modified)
/trunk/ACP Help/relnotes.htm (Modified)
/trunk/ACP Interop Assembly (Scheduler)/Interop.ACP.8.0.dll (Modified)
/trunk/ACP Interop Assembly (Scheduler)/Interop.ACP.dll (Modified)
/trunk/ACP Interop Assembly (Scheduler)/MakeAcpInterop.bat (Modified)
/trunk/ACP.vbp (Modified)
/trunk/AutoGuiding.cls (Modified)
/trunk/Main.bas (Modified)
/trunk/acp-ref.exe (Modified)
/trunk/frmPrefs.frm (Modified)
/trunk/frmPrefs.frx (Modified)

 
 

  
Check-in comment
  
Checkpoint at end of day. New ACP config feature and API completed and tested, interop assembly for Scheduler tested. Needs docs and script changes.
GEM:626

 

In addition to aadding a new property Prefs.Autoguiding.ReverseYonFlip (bool) I made this read/write along with Prefs.Autoguiding.SensorAngle and Prefs.Autoguiding.SensorPlateScale. This is in anticipation of an automatic guider configuration process. At a minimum, the CalibrateGuider script can write back the SensorAngle!

Bumped to top priority. There is an email (unfortunately!!) conversation going which I started a few days ago. Turns out the drivers have reversal switches, MaxIm has reversal switches, so I don't need more!

Removed links to ACP-478 and ACP-586, now handled by separate guide sensor angle input in ACP.

Removed link to ACP-629, not related

Added more of these related issues