[ACP-826]  Eliminate separate RotatorController
Type Change Request
Priority Medium
Severity Trivial
Component Whole Product
Fixed In Version [7.0] 7.0
Versions Affected [6.0.4] 6.0 Hot Fix 4
Severity Closed
Resolution Complete
Reported By Bob Denny
Resources Bob Denny
Start Date 3/29/2012

Description 
Bring the guiding settings for rotator into the main ACP UI. Eliminate the Rotator Controller and provide for internal connection to the rotator, or just let the scripts do it??? The goal is to eliminate the separate rotcontrol.exe.

Comments
6/26/2012 11:03:04 AM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  418
 

 

  Affected files
  /trunk/New Content Development/DC3 Style & Template/MarkupPreHead.tid.html (Modified)
/trunk/New Content Development/author.html (Modified)
/trunk/New Content Development/index.asp (Modified)
/trunk/WebDocs/author.html (Modified)
/trunk/WebDocs/index.asp (Modified)

 

 

  Check-in comment
  Pick up Rotator.Available in web UI (no more RotatorInfo.txt!)
GEM:826
4/6/2012 2:22:05 PM   Bob Denny 
DO NOT CLOSE UNTIL YOU DO THE DOCUMENTATION IN ACP HELP, ROTATOR CONTROL
4/2/2012 11:29:33 AM   Bob Denny 
OK! THis looks pretty good. I've tested it rather thoroughly, including the web UI. It caused the web UI to improve! It is no longer necessary to be running a plan to see the rotator info.  Switch to Testing.
4/2/2012 11:28:03 AM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  386
 

 

  Affected files
  /trunk/ACP Help/relnotes.htm (Modified)
/trunk/AcquireSupport.wsc (Modified)
/trunk/New Content Development/author.html (Modified)
/trunk/Script Components Master/AcquireSupport.wsc (Modified)
/trunk/Scripts/AcquireImages.js (Modified)
/trunk/WebDocs/ac/aacqflat.asp (Modified)
/trunk/WebDocs/ac/adefflat.asp (Modified)
/trunk/WebDocs/ac/aequip.asp (Modified)
/trunk/WebDocs/ac/asystemstatus.asp (Modified)
/trunk/acp-ref.exe (Modified)
/trunk/main.frm (Modified)

 

 

  Check-in comment
  Remainder of changes for this, including the web UI. Ran some tests with observing plans. AcquireScheduler uses SUP.RotXxx which is still valid. I think this is it.
GEM:826
4/1/2012 3:50:49 PM   Bob Denny 
Setting this aside for the moment, for refactoring of the telemetry and display refreshing in ACP-831.
4/1/2012 3:46:45 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  384
 

 

  Affected files
  /trunk/ACP Help/ProgRef.chm (Modified)
/trunk/ACP Help/Programmer's Reference/ACP2 Programmer's Reference.mdb (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.chm (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhc (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhk (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhp (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefCLASSRotator.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorMETHHalt.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorMETHMoveAbsolute.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorPROPAvailable.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorPROPIsMoving.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorPROPName.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorPROPPABias.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefRotatorPROPPosition.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilPROPRotator.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilPROPRotatorConnected.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilPROPUserInterfaceLive.htm (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefUtilPROPWeather.htm (Modified)
/trunk/ASPEngine.cls (Modified)
/trunk/DomeControl.cls (Modified)

 

 

  Check-in comment
  Checkpoint - The changes to ACP.EXE and the API documentation is done. Stopping this for ACP-831 (refactor telemetry refreshing)
GEM:826
3/31/2012 7:37:23 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  383
 

 

  Affected files
  /trunk/ASPEngine.cls (Modified)
/trunk/Rotator.cls (Modified)
/trunk/main.frm (Modified)

 

 

  Check-in comment
  A few more things I caught while doing 130 (Weather unsafe time)
GEM:826
3/31/2012 7:35:01 PM   Bob Denny 
Add 12 more hours to time estimate. This baby is huge.
3/31/2012 5:07:59 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  380
 

 

  Affected files
  /trunk/COM_Errors.bas (Modified)
/trunk/Rotator.cls (Modified)
/trunk/main.frm (Modified)

 

 

  Check-in comment
  Checkpoint commit - end of the day on this.
GEM:826
3/31/2012 2:33:04 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  379
 

 

  Affected files
  /trunk/ACP.vbp (Modified)
/trunk/COM_Errors.bas (Modified)
/trunk/Main.bas (Modified)
/trunk/Rotator.cls (Added)
/trunk/Utilities.bas (Modified)
/trunk/frmGo.frm (Modified)
/trunk/main.frm (Modified)

 

 

  Check-in comment
  Checkpoint commit. It compiles and runs though the console indicators are inop and none of its API has been tested.
GEM:826
3/30/2012 12:39:02 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  378
 

 

  Affected files
  /trunk/ACP Help/relnotes.htm (Modified)
/trunk/AcquireSupport.wsc (Modified)
/trunk/Main.bas (Modified)
/trunk/Script Components Master/AcquireSupport.wsc (Modified)
/trunk/Scripts/AcquireImages.js (Modified)

 

 

  Check-in comment
  Script changes for the API changes in previous commit.
GEM:826
3/29/2012 5:39:42 PM   Bob Denny 

 

  SVN Comment
 

 

  Author
  rbdenny
 

 

  Repository
  svn+ssh://rbdenny@a2_svn_dc3/home/rbdenny/svn/astro/acp
 

 

  SVN Revision
  377
 

 

  Affected files
  /trunk/ACP Help/ProgRef.chm (Modified)
/trunk/ACP Help/Programmer's Reference/ACP2 Programmer's Reference.mdb (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.chm (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhc (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRef.hhk (Modified)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPAdaptiveOptics.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPCycleTime.htm (Deleted)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPExternalGuider.htm (Deleted)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPSensorAngle.htm (Added)
/trunk/ACP Help/Programmer's Reference/doc/ProgRefAutoGuidingPROPSensorType.htm (Added)
/trunk/ACP Help/relnotes.htm (Modified)
/trunk/ACP Interop Assembly (Scheduler)/Interop.ACP.dll (Modified)
/trunk/ACP.vbp (Modified)
/trunk/AutoGuiding.cls (Modified)
/trunk/Main.bas (Modified)
/trunk/acp-ref.exe (Modified)
/trunk/frmPrefs.frm (Modified)
/trunk/frmPrefs.frx (Modified)

 

 

  Check-in comment
  Start of bringing Rotator Controller and AoInfo into ACP. Removed some API members and added others. Reorganized guide tab of prefs. Programmer's reference updated. Release notes updated. TODO: All scripts with reference changed API members, and bring the rotator itself into ACP.
GEM:826
3/29/2012 5:12:11 PM   Bob Denny 
Coming right along. The Guiding UI is basically done, as well as the API changes and the documentation for same. I shuffled things around and got everything there. The only things left are the rotator connect/disconnect and the ACP Rotator "hub". I'm going to replace the Target box on the console with a Rotator box. Anyway, time to commit.






NOTES: The AutoGuiding.ExternalGuider and AutoGuiding.CycleTime properties are gone. New properties are AutoGuiding.SensorType, AutoGuiding.SensorAngle, and AutoGuiding.AdaptiveOptics. The latter takes care of ACP-821 which  I closed as a dupe. I'll track the commits and time for that in this ticket.







TODO: AcquireSupport and the other scripts that use The internal/OffAxis and sensor rotation from the Rotator Controller, ExternalGuider and CycleTime from ACP.Prefs.AutoGuiding, and the AO or Not from AoInfo now have to be changed. Not done yet. The Getting Started and AutoGuiding documentation now has to change, as well as the Rotator stuff. Add a new menu in place of the Dome menu, for Rotator, Setup and Conn/Disc. Also need a way to see the mech and PA angles (where Target box in console is now).
3/28/2012 8:53:55 PM   Bob Denny 
Not enough room on the Guiding tab of prefs. Can get rid of CycleTime (just use 2 sec.) as it is just part of a sanity startup time. Leave it stubbed out in the API, fed from the registry.






Probably should have a Rotator tab in prefs. Put the Int/OAG and sensor angle things there. Dim them if the External Guidescope checkbox is set on the Guider tab.







Replace the Target area with a Rotator Control UI. No one uses the Target area. 
3/28/2012 8:41:02 PM   Bob Denny 
Replace the Dome menu, which is duplicated in the little Dome Control panel, with a new Rotator menu with Connect and Setup. How can we see what's going on with it?